feat: Add rx timestamp to rinfo payload #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glenne, LGTM! However, it does not match NodeJS dgram API. I must check if we could induce inconsistencies with this PR. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2020
# [4.1.0](v4.0.4...v4.1.0) (2020-12-05) ### Features * Add rx timestamp to rinfo payload ([#146](#146)) ([c468a39](c468a39))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @Rapsssito, your efforts are appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For doing time sync with UDP packets, the best available rx timestamp is needed to avoid delays introduced in callback event reporting. This pull request captures the time at a low level and passes it in the rinfo callback object as a millisecond timestamp. Verified on Android and iOS.